feat(app): enable the supported relay by default - #921
Conversation
8dfaf61 to
00efc21
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00efc21186
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
00efc21 to
16cecec
Compare
|
@miravoss26 could you review exact head |
16cecec to
84c5123
Compare
|
@miravoss26 the exact relay-default diff is now rebased on master at |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84c51238bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review @miravoss26 please refresh review on exact head |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
98f2b25 to
651e7a2
Compare
Signed-off-by: Fredrik Ahlgren <[email protected]>
651e7a2 to
8af080f
Compare
|
@codex review @miravoss26 please review exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8af080f7c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Fredrik Ahlgren <[email protected]>
|
@codex review @miravoss26 please review exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e295fe48e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Exact head |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What changes
app_linksection as enabled, so upgraded boxes use the supported FTW app relay without a YAML edit.app_link.enabled: false, YAMLapp_link:/null/{}, and JSON"app_link": nullas opt-outs.The relay endpoint and protocol remain fixed. This change does not alter pairing keys, command checks, or hardware control.
Compatibility proof
The round-trip tests start with an old YAML file that has no
app_link, load it, fetch it throughGET /api/config, save that response throughPOST /api/config, read the file again, and prove the app link stays on after restart. Separate tests keep explicit false, YAML null and an empty section off. The API test proves JSON null is stored as an explicit opt-out and stays off after restart.Verification
Head:
e295fe48e8d44b49c326c256e8a2e40c0f09cf04git range-diff: the first two feat(app): enable the supported relay by default #921 commits remain patch-identical after restacking onmaster1acb8097ec51b12fa744ff65f525df4c280435c5.0407921a54957a6d82a38130181847ad4a71d9f9.8af080f7: an omittedapp_linkproduced a false app-link restart reason. It passes after the third commit, while explicit JSON null and false still turn the link off and require restart.cmd/ftwapp-link API race tests passed 20 times.internal/configrestart/app-link race tests passed 20 times.8af080f7passed all 340 web tests andmake verify, including 167 optimizer tests, Go tests, compose migration, module boundaries, exact-image promotion, vet, and build. Exact-head GitHub checks must also pass before merge.Human browser gate before merge
Serve this exact head from a box. Check both desktop at 1440 x 900 and a narrow mobile viewport at 390 x 844.
app_link, Settings -> FTW app opens with the checkbox checked. Save and restart; it stays checked and the running status becomes available.app_link.enabled: false, and once with an empty or null YAML section, the checkbox opens unchecked. Save and restart; it stays off and no pairing action is enabled.Show pairing codebecomes enabled. The owner explanation, QR, expiry line, and spoken-code fallback fit without clipping; the QR stays square and scans from the phone.Remove, andLet someone see this homefit and remain usable. The viewer QR and its access explanation also fit and scan.Do not merge until a human checks every box above.
Release order
#928 and #932 are already on
master. Merge this PR only after the browser gate passes. Then let the release workflow refresh Version Packages PR #824 from the resultingmaster; do not merge the current #824 head first.